api: ensure API times used for trigger comparisons #5509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `trigger` package now returns `metav1.MicroTime` instead of stdlib `time.Time` for trigger (start/restart/stop) timestamps. There's a ripple effect for some internal state types on reconcilers which went through the same conversion. Comparisons are also all now made via the `timecmp` package using the API types. Primarily, this fixes flakiness for tests on Windows; it's fairly unlikely that the cases here would cause unexpected behavior at runtime because real world events (e.g. clicking a button) are not performed instantaneously.
Because `!timecmp.BeforeOrEqual` is confusing as heck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
triggerpackage now returnsmetav1.MicroTimeinstead ofstdlib
time.Timefor trigger (start/restart/stop) timestamps.There's a ripple effect for some internal state types on reconcilers
which went through the same conversion.
Comparisons are also all now made via the
timecmppackage usingthe API types.
Primarily, this fixes flakiness for tests on Windows; it's fairly
unlikely that the cases here would cause unexpected behavior at
runtime because real world events (e.g. clicking a button) are not
performed instantaneously.
Testing
Previously, I'd pretty consistently see failures with just a few (~10) test runs for
TestCancelButton(ininternal/engine) on a Windows 11 machine.After these changes, 500 runs passes: