web: add pagination to resource list tables in Table View to mirror Detail View #5511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #13307: Perf mitigation: Add pagination for resources in Table View. |
nicks
approved these changes
Feb 16, 2022
lizzthabet
force-pushed
the
lizz/fix/add-pagination-to-table-view
branch
from
e0fbaa2 to
a65faab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
...Show Morebutton to each table in Table View when the resource list exceeds twenty items. It pulls out the shared code from Detail View into its own component. These changes will help mitigate the performance issues we're seeing with displaying many resources (#5495) while we investigate root causes.There may be some subtleties in how we want the list truncation to work, but for now, I took the easiest approach. A couple examples I can think of:
Closes ch13307