buildcontrol: avoid spurious changes to the 'waiting' state on disabled resources #5516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
landism
approved these changes
Feb 17, 2022
…ed resources Before this change, the "waiting" state of disabled resources would be continuously in flux. This is expensive and doesn't even make sense from a data model perspective - a disabled resource isn't waiting or being held.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @landism, @milas,
Please review the following commits I made in branch nicks/holds:
38001b7 (2022-02-16 19:57:15 -0500)
buildcontrol: avoid spurious changes to the 'waiting' state on disabled resources
Before this change, the "waiting" state of disabled resources would be
continuously in flux. This is expensive and doesn't even make sense from a data
model perspective - a disabled resource isn't waiting or being held.
Code review reminders, by giving a LGTM you attest that: