Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: add github author names to the release changelog #5528

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

nicks
Copy link
Member

@nicks nicks commented Feb 22, 2022

Hello @lianmakesthings,

Please review the following commits I made in branch nicks/contributors:

bfc6338 (2022-02-22 11:01:44 -0500)
release: add github author names to the release changelog

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks
Copy link
Member Author

nicks commented Feb 22, 2022

AHHHHH i can't believe it was this easy.

@lianmakesthings
Copy link

Is there a place where I could see what the result looks like?

@nicks
Copy link
Member Author

nicks commented Feb 22, 2022

@lianmakesthings here's what it looks like on the goreleaser project: https://github.com/goreleaser/goreleaser/releases/tag/v1.5.0

note both the github usernames on the individual PRs and the "Contributors" section

@nicks nicks merged commit 2634257 into master Feb 22, 2022
@nicks nicks deleted the nicks/contributors branch February 22, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants