Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: memoize resource selection provider #5530

Merged
merged 1 commit into from
Feb 22, 2022
Merged

web: memoize resource selection provider #5530

merged 1 commit into from
Feb 22, 2022

Conversation

nicks
Copy link
Member

@nicks nicks commented Feb 22, 2022

Hello @landism, @lizzthabet,

Please review the following commits I made in branch nicks/selection:

c104669 (2022-02-22 13:59:02 -0500)
web: memoize resource selection provider

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested review from landism and lizzthabet February 22, 2022 18:59
@nicks nicks merged commit 58ec004 into master Feb 22, 2022
@nicks nicks deleted the nicks/selection branch February 22, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants