Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: fix sidebar keyboard navigation for labels #5534

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Conversation

nicks
Copy link
Member

@nicks nicks commented Feb 23, 2022

Hello @lizzthabet, @landism,

Please review the following commits I made in branch nicks/ch13283:

defc9f3 (2022-02-23 12:55:16 -0500)
web: fix sidebar keyboard navigation for labels

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested review from landism and lizzthabet February 23, 2022 17:56
@shortcut-integration
Copy link

Copy link
Member

@landism landism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@nicks nicks merged commit ba2bbf2 into master Mar 1, 2022
@nicks nicks deleted the nicks/ch13283 branch March 1, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants