web: make build event logs sticky #5539
Conversation
|
This pull request has been linked to Shortcut Story #13284: As a user, I see the log stream divider sticky at top of page. |
| @@ -85,6 +85,14 @@ function newLineEl( | |||
| if (buildEvent === "init") { | |||
| classes.push("is-buildEvent") | |||
| classes.push("is-buildEvent-init") | |||
|
|
|||
| if (showManifestPrefix) { | |||
| text += ` • ${line.manifestName}` | |||
There was a problem hiding this comment.
(nit) it'd be nice to have a short comment here that explains the reason for suffixing with the manifest name.
web/src/LogLine.scss
Outdated
| } | ||
| .LogLine:not(.is-buildEvent) + .LogLine.is-buildEvent.is-sticky, | ||
| .LogLine.is-buildEvent.is-sticky:first-child { | ||
| top: -8px; // For position:sticky with padding on LogPane |
There was a problem hiding this comment.
definitely not a merge-blocker, but i still see the 8px of padding when i scroll all the way to the top of the log pane.
fiddling around in the browser, i was able to remove it by setting the log pane padding to 0 0 8px 0 and then this can be set to 0.
There was a problem hiding this comment.
oh that's intentional! that's what it looks like at head (go here https://storybook.tilt.dev/?path=/story/new-ui-overviewresourcepane--ten-resources-with-log-store and click "all resources")
There was a problem hiding this comment.
ahh, interesting! nevermind then.
| @@ -85,6 +85,14 @@ function newLineEl( | |||
| if (buildEvent === "init") { | |||
| classes.push("is-buildEvent") | |||
| classes.push("is-buildEvent-init") | |||
|
|
|||
| if (showManifestPrefix) { | |||
| text += ` • ${line.manifestName}` | |||
Hello @hyu, @lizzthabet,
Please review the following commits I made in branch nicks/ch13284:
fc1623a (2022-02-24 19:38:56 -0500)
web: make build event logs sticky
Code review reminders, by giving a LGTM you attest that: