store: move HUD view rendering into the HUD package #5545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicks
commented
Feb 28, 2022
| } | ||
|
|
||
| ms := mt.State | ||
| if ms.DisableState == v1alpha1.DisableStateDisabled { |
There was a problem hiding this comment.
this is the only line that changed; everything here is a straight-up move
nicks
force-pushed
the
nicks/issue5543
branch
from
c19167d to
69d5878
Compare
landism
approved these changes
Feb 28, 2022
also moves HUD view rendering into the HUD package Fixes #5543
nicks
force-pushed
the
nicks/issue5543
branch
from
69d5878 to
c0616f9
Compare
|
done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @landism,
Please review the following commits I made in branch nicks/issue5543:
c19167d (2022-02-28 14:32:30 -0500)
store: move HUD view rendering into the HUD package
Also: skip disabled resources when rendering the legacy HUD
Fixes #5543
Code review reminders, by giving a LGTM you attest that: