Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: add Table View and Detail View icons with All Resources log link #5546

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

lizzthabet
Copy link
Contributor

@lizzthabet lizzthabet commented Feb 28, 2022

Update main view navigation menu with icon, improve a11y markup, and add All Resources link in Detail View

2022-02-28 14 42 34

See designs here.

Closes ch13096.

@lizzthabet lizzthabet self-assigned this Feb 28, 2022
@lizzthabet lizzthabet requested review from landism and nicks February 28, 2022 21:02
@lizzthabet lizzthabet marked this pull request as ready for review February 28, 2022 21:02
@shortcut-integration
Copy link

@lizzthabet lizzthabet force-pushed the lizz/chore/improve-view-menu branch from 797e714 to 6e53c35 Compare February 28, 2022 21:05
<MenuButton onClick={props.snapshot.openModal}>
<MenuButton
onClick={props.snapshot.openModal}
role="menuitem"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

…p, and add All Resources link in Detail View
@lizzthabet lizzthabet force-pushed the lizz/chore/improve-view-menu branch from 6e53c35 to 4530ca9 Compare March 1, 2022 18:27
@lizzthabet lizzthabet merged commit b66f981 into master Mar 1, 2022
@lizzthabet lizzthabet deleted the lizz/chore/improve-view-menu branch March 1, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants