Preserve dc_resource state between docker_compose calls #5561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicksieger
commented
Mar 4, 2022
nicksieger
commented
- tiltfile: preserve dc_resource state
- chore: updated go mod vendor changes
landism
approved these changes
Mar 4, 2022
| svc.TriggerMode = previousSvc.TriggerMode | ||
| svc.resourceDeps = previousSvc.resourceDeps | ||
| svc.Labels = previousSvc.Labels | ||
| svc.Links = previousSvc.Links |
There was a problem hiding this comment.
We also need svc.imageRefFromUser here.
It's probably worth a comment on this block and in dc_resource indicating they need to be kept in sync.
Or, if you wanna get fancy, you could do what we do with k8s_resource: make a struct that just has the dc_resource args and store them separately from the DC config parse results and combine everything at the end of tiltfile execution.
|
Tested locally and seems to solve the issue #5558 |
lianmakesthings
approved these changes
Mar 4, 2022
|
I started on some changes to do what Matt is suggesting, but I'll add them in a follow-up PR to not block the release today. |
nicksieger
added a commit
that referenced
this pull request
Mar 4, 2022
Follow-up to #5561 that extracts options separate from DC services, so that dc_resource state is more easily preserved across docker_compose calls.
nicksieger
added a commit
that referenced
this pull request
Mar 7, 2022
* tiltfile: extract dcResourceOptions Follow-up to #5561 that extracts options separate from DC services, so that dc_resource state is more easily preserved across docker_compose calls. * tiltfile: combine previous+current links, labels, and resource deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.