Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetesapply: when disabling a custom deploy, use the delete cmd, not implicit object cleanup #5578

Merged
merged 1 commit into from
Mar 9, 2022
Merged

kubernetesapply: when disabling a custom deploy, use the delete cmd, not implicit object cleanup #5578

merged 1 commit into from
Mar 9, 2022

Conversation

nicks
Copy link
Member

@nicks nicks commented Mar 9, 2022

Hello @milas, @landism,

Please review the following commits I made in branch nicks/destroy:

7ee196d (2022-03-09 15:04:52 -0500)
kubernetesapply: when disabling a custom deploy, use the delete cmd, not implicit object cleanup

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested review from landism and milas March 9, 2022 20:05
@nicks nicks merged commit 097b7f5 into master Mar 9, 2022
@nicks nicks deleted the nicks/destroy branch March 9, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milas milas milas approved these changes

@landism landism Awaiting requested review from landism

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicks @milas