cluster: refactor client initialization #5618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The motivation here is in preparation for cluster status polling to make it possible to write more robust unit tests. Currently, the reconciler behaved very differently when provided with fake clients for test. (In fact, there was actually a bug as a result of this! The `ConnectedAt` timestamp handling was different for tests.) Now, there's factories for both K8s/Docker clients that get injected, and tests can override these. Helper methods are offered to return a static client for all created connections or an error. This latter part is critical to simulating errors with fake clients in a controlled fashion to verify the (forthcoming) retry behavior.
nicksieger
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation here is in preparation for cluster status polling
to make it possible to write more robust unit tests. Currently,
the reconciler behaved very differently when provided with fake
clients for test. (In fact, there was actually a bug as a result
of this! The
ConnectedAttimestamp handling was different fortests.)
Now, there's factories for both K8s/Docker clients that get
injected, and tests can override these. Helper methods are
offered to return a static client for all created connections
or an error.
This latter part is critical to simulating errors with fake clients
in a controlled fashion to verify the (forthcoming) retry behavior.