Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockercomposeservice: publish the container name to the status API #5620

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

nicks
Copy link
Member

@nicks nicks commented Mar 22, 2022

Hello @milas, @nicksieger,

Please review the following commits I made in branch nicks/containername:

2f6b5eb (2022-03-22 17:11:17 -0400)
dockercomposeservice: publish the container name to the status API
This makes it a bit easier to print human-readable output.

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

This makes it a bit easier to print human-readable output.
@nicks nicks requested review from milas and nicksieger March 22, 2022 21:11
@nicks nicks merged commit 1174a1e into master Mar 22, 2022
@nicks nicks deleted the nicks/containername branch March 22, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants