feature: mark the live_update_v2 flag as obsolete #5626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i'll wait to merge until after today's release |
nicks
force-pushed
the
nicks/liveupdateflag
branch
from
6280325 to
2651a5f
Compare
|
this actually revealed a real bug! when the new live-updater is running, and the Dockerfile changes, we sometimes don't realize that we have to rebuild a new image. but this has been a bug for a while so will just file it separately. |
|
oh wait, scratch that, i misunderstood what the test was telling me. |
nicks
force-pushed
the
nicks/liveupdateflag
branch
from
2651a5f to
0aeab5f
Compare
nicks
commented
Mar 24, 2022
| @@ -908,24 +907,6 @@ k8s_yaml('snack.yaml') | |||
| // (i.e. check that we called BuildAndDeploy with no pre-existing state) | |||
| assert.False(t, call.oneImageState().HasLastResult()) | |||
|
|
|||
| var manifest model.Manifest | |||
There was a problem hiding this comment.
this test had a weird dependency on BuildController handling the live-update, so i just removed the part of the test that required this.
landism
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @landism, @milas,
Please review the following commits I made in branch nicks/liveupdateflag:
6280325 (2022-03-24 15:28:47 -0400)
feature: mark the live_update_v2 flag as obsolete
Code review reminders, by giving a LGTM you attest that: