Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

liveupdate: display exec errors correctly #5636

Merged
merged 1 commit into from
Mar 28, 2022
Merged

liveupdate: display exec errors correctly #5636

merged 1 commit into from
Mar 28, 2022

Conversation

nicks
Copy link
Member

@nicks nicks commented Mar 28, 2022

Hello @landism,

Please review the following commits I made in branch nicks/execerror:

4b7eb16 (2022-03-28 16:00:17 -0400)
liveupdate: display exec errors correctly
fixes #5635

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested a review from landism March 28, 2022 20:00
@nicks nicks merged commit 324cf90 into master Mar 28, 2022
@nicks nicks deleted the nicks/execerror branch March 28, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

live update failure not recognized by engine / highlighted by UI
2 participants