Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: indexing for DockerImage/CmdImage #5665

Merged
merged 4 commits into from
Apr 6, 2022
Merged

Conversation

milas
Copy link
Contributor

@milas milas commented Apr 6, 2022

Add indexer.Indexer to the image reconcilers and trigger reconciliation on Cluster change.

Neither CmdImage nor DockerImage are using the Cluster for anything yet; this is a
mechanical PR to set things up so they can being using it for inferring image properties.

@milas milas requested a review from lizzthabet April 6, 2022 12:30
Copy link
Contributor

@lizzthabet lizzthabet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! i'm not sure if the failing tests are related to the circle ci incident earlier today. 👀

@milas
Copy link
Contributor Author

milas commented Apr 6, 2022

I'm almost positive the flaky integration tests are CI-related (my guess is that due to the CircleCI backlog, there's a lot more resource contention/overprovisioning than usual), but I needed to merge in latest master to resolve some conflicts regardless, so we'll see if this new build passes 🤞

@milas milas merged commit 0bab23d into master Apr 6, 2022
@milas milas deleted the milas/images-cluster-idx branch April 6, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants