web: add Cluster Status to global nav in storybook #5674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a cluster button to the global navigation menu that displays information from the cluster API object. Since we're still adding information to the cluster API object, I've only passed the cluster info to the nav in storybook components, so the cluster button won't display for any users yet. When we're ready to have cluster information visible in the dashboard, I'll put up a separate PR.
The best way to test is to run
web/storybook.tiltfileand look atShared > Header Bar > Nav(with and without error) stories. You can manipulate theclusterConnection()method intestdata.tsxto change the cluster API object.Cluster button and dialog in a healthy state:
Cluster button and dialog with an error:
