Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: improve unrecoverable error message #5689

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Conversation

milas
Copy link
Contributor

@milas milas commented Apr 13, 2022

Until the cluster_refresh feature is done, initialization errors
for the cluster are unrecoverable, as not all parts of Tilt know
how to re-initialize the client/themsleves properly on change.

Tilt web UI showing a cluster error message

The error message is now wrapped with some additional context and
a notice that Tilt needs to be restarted after fixing the issue.

Until the `cluster_refresh` feature is done, initialization errors
for the cluster are unrecoverable, as not all parts of Tilt know
how to re-initialize the client/themsleves properly on change.

The error message is now wrapped with some additional context and
a notice that Tilt needs to be restarted after fixing the issue.
@milas milas requested a review from lizzthabet April 13, 2022 18:49
@milas milas self-assigned this Apr 13, 2022
Copy link
Contributor

@lizzthabet lizzthabet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@milas milas merged commit dfe2a3f into master Apr 14, 2022
@milas milas deleted the milas/cluster-error branch April 14, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants