docker: fix spurious double builds on Dockerfile change #5742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not _watch_ the Dockerfile from the image target, as this is
handled by the Tiltfile, which provides the full contents to the
target in-memory (i.e. the on-disk Dockerfile isn't actually used
when we execute the build).
This prevents race conditions from them both watching it, and
ensures that the flow always goes:
(Dockerfile change) -> Tiltfile execute -> image build
Fixes #5586.
nicks
approved these changes
Apr 29, 2022
| contextIgnores = append(contextIgnores, model.DockerignoresToIgnores(dockerignores)...) | ||
|
|
||
| for i := range contextIgnores { | ||
| fileWatchIgnores = append(fileWatchIgnores, *contextIgnores[i].DeepCopy()) |
There was a problem hiding this comment.
fyi - i think the k8s api convention is to only do a copy when you know you're going to modify the object
There was a problem hiding this comment.
Yeah, this is probably extra defensive but given the lifetime of these items and how much they get passed around (+ the fact that we've got two intersecting sets of them originating from the same objects), I figured an extra copy was worth saving potential future debugging headache down the road
[skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not watch the Dockerfile from the image target, as this is
handled by the Tiltfile, which provides the full contents to the
target in-memory (i.e. the on-disk Dockerfile isn't actually used
when we execute the build).
This prevents race conditions from them both watching it, and
ensures that the flow always goes:
(Dockerfile change) -> Tiltfile execute -> image build
Fixes #5586.