Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

watch: optimization to help avoid inotify nodes for large file trees #5769

Merged
merged 1 commit into from
May 5, 2022

Conversation

nicks
Copy link
Member

@nicks nicks commented May 5, 2022

Hello @milas, @nicksieger,

Please review the following commits I made in branch nicks/inotify:

daaaf61 (2022-05-04 19:58:46 -0400)
watch: optimization to help avoid inotify nodes for large file trees
fixes #5764

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested review from milas and nicksieger May 5, 2022 00:02
@nicks nicks force-pushed the nicks/inotify branch from daaaf61 to 7c3b771 Compare May 5, 2022 00:03
@nicks nicks force-pushed the nicks/inotify branch from 7c3b771 to 3feefaf Compare May 5, 2022 00:04
@nicks
Copy link
Member Author

nicks commented May 5, 2022

filewatching makes me so sad, it's never easy

@nicks nicks merged commit e5fe788 into master May 5, 2022
@nicks nicks deleted the nicks/inotify branch May 5, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long delay before file watcher started working on big directory
3 participants