-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web: add download snapshot dialog behind feature flag #5783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizzthabet
force-pushed
the
matt/save_snapshot
branch
from
May 6, 2022 17:11
509753b
to
1a26aff
Compare
This pull request has been linked to Shortcut Story #13474: As user, download snapshot.json via Tilt Web. |
milas
approved these changes
May 6, 2022
pushed a fix! |
nicks
reviewed
May 6, 2022
lizzthabet
commented
May 9, 2022
lizzthabet
commented
May 9, 2022
nicks
approved these changes
May 9, 2022
lizzthabet
force-pushed
the
matt/save_snapshot
branch
from
May 9, 2022 22:37
92ac113
to
68d317c
Compare
lizzthabet
force-pushed
the
matt/save_snapshot
branch
from
May 9, 2022 22:46
68d317c
to
eb42f0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
offline_snapshot_creation
SnapshotProvider
state to move data there so that the float dialog could live in theGlobalNav
.)Thanks to @landism for doing the majority of this PR!
Leaving this in draft mode until I have a couple tests added, but otherwise nothing else should change.Closes ch13474.