Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: add download snapshot dialog behind feature flag #5783

Merged
merged 8 commits into from
May 10, 2022

Conversation

lizzthabet
Copy link
Contributor

@lizzthabet lizzthabet commented May 6, 2022

  • Add a new snapshot dialog for downloading a snapshot file directly, only visible behind a feature flag; this dialog is styled like the other menu item dialogs.
  • Add a new feature flag named offline_snapshot_creation
  • Add a dialog anchor to the HUD state for the float dialog to display. (Because snapshot creation grabs data from the HUD state, I opted for this change, rather than a larger refactor of the SnapshotProvider state to move data there so that the float dialog could live in the GlobalNav.)

Thanks to @landism for doing the majority of this PR! Leaving this in draft mode until I have a couple tests added, but otherwise nothing else should change.

Screen Shot 2022-05-06 at 12 59 14 PM

Closes ch13474.

@lizzthabet lizzthabet requested review from nicksieger, nicks and milas May 6, 2022 17:09
@lizzthabet lizzthabet self-assigned this May 6, 2022
@lizzthabet lizzthabet force-pushed the matt/save_snapshot branch from 509753b to 1a26aff Compare May 6, 2022 17:11
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #13474: As user, download snapshot.json via Tilt Web.

web/src/ShareSnapshotModal.tsx Show resolved Hide resolved
@landism
Copy link
Member

landism commented May 6, 2022

I haven't figured out why, but this breaks online snapshot creation for me:
image

(and apparently this was true in my original branch as well).

I'll update if I figure it out before EOD.

@landism
Copy link
Member

landism commented May 6, 2022

I'll update if I figure it out before EOD.

pushed a fix!

@lizzthabet lizzthabet marked this pull request as ready for review May 9, 2022 18:18
@lizzthabet lizzthabet requested review from nicks and milas May 9, 2022 18:18
@lizzthabet lizzthabet force-pushed the matt/save_snapshot branch from 92ac113 to 68d317c Compare May 9, 2022 22:37
@lizzthabet lizzthabet force-pushed the matt/save_snapshot branch from 68d317c to eb42f0e Compare May 9, 2022 22:46
@lizzthabet lizzthabet merged commit e86a628 into master May 10, 2022
@lizzthabet lizzthabet deleted the matt/save_snapshot branch May 10, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants