Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockercompose: move helper functions around #5797

Merged
merged 1 commit into from
May 10, 2022
Merged

dockercompose: move helper functions around #5797

merged 1 commit into from
May 10, 2022

Conversation

nicks
Copy link
Member

@nicks nicks commented May 10, 2022

Hello @nicks,

Please review the following commits I made in branch nicks/dclogs2:

55b873e (2022-05-10 13:03:10 -0400)
dockercompose: move helper functions around

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks merged commit 403aa69 into master May 10, 2022
@nicks nicks deleted the nicks/dclogs2 branch May 10, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant