Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: upgrade protobuf dependencies #5807

Merged
merged 1 commit into from
May 12, 2022
Merged

scripts: upgrade protobuf dependencies #5807

merged 1 commit into from
May 12, 2022

Conversation

nicks
Copy link
Member

@nicks nicks commented May 11, 2022

Hello @milas,

Please review the following commits I made in branch nicks/pb:

14d7af9 (2022-05-11 18:58:52 -0400)
scripts: upgrade protobuf dependencies

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested a review from milas May 11, 2022 22:59
@nicks
Copy link
Member Author

nicks commented May 11, 2022

grpc changed a bunch of package names and split their go codegen into two separate generators (one for the data models and one for the server stubs)

Copy link
Contributor

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😵

@nicks nicks merged commit d71dfdf into master May 12, 2022
@nicks nicks deleted the nicks/pb branch May 12, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants