web: replace node-sass with sass #5846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `node-sass` package has been deprecated and superseded by the
`sass` package.
The `node-sass` package used a C library via `node-gyp`, which itself
requires Python to wrangle the compilation. The version of `node-sass`
we were using was old and thus relied on an old version of `node-gyp`,
which only supported <= Python 3.8.
This caused problems with Homebrew builds with embedded assets, as
Python 3.9 is used there, so `node-gyp` would error out.
While it's theoretically possible to upgrade `node-sass` to a newer
version to transitively get a newer `node-gyp` that will not bail on
Python 3.9, that did NOT work out of the box, and the recommended
solution for the problem was...switch to `sass`, which does not have
any native code requirements and is actively supported.
As part of this, the `sass` compiler emitted warnings on deprecated
division outside of `calc()`, so those have all been updated to avoid
producing a bunch of noise in the build log.
I did a visual pass after this change and didn't see any differences
in styling in Chrome on macOS.
tl;dr: This will dramatically simplify producing Homebrew builds with
embedded assets by sidestepping the need for a Python/`node-gyp`
build chain just for bundling the UI assets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
node-sasspackage has been deprecated and superseded by thesasspackage.The
node-sasspackage used a C library vianode-gyp, which itselfrequires Python to wrangle the compilation. The version of
node-sasswe were using was old and thus relied on an old version of
node-gyp,which only supported <= Python 3.8.
This caused problems with Homebrew builds with embedded assets, as
Python 3.9 is used there, so
node-gypwould error out.While it's theoretically possible to upgrade
node-sassto a newerversion to transitively get a newer
node-gypthat will not bail onPython 3.9, that did NOT work out of the box, and the recommended
solution for the problem was...switch to
sass, which does not haveany native code requirements and is actively supported.
As part of this, the
sasscompiler emitted warnings on deprecateddivision outside of
calc(), so those have all been updated to avoidproducing a bunch of noise in the build log.
I did a visual pass after this change and didn't see any differences
in styling in Chrome on macOS.
tl;dr: This will dramatically simplify producing Homebrew builds with
embedded assets by sidestepping the need for a Python/
node-gypbuild chain just for bundling the UI assets.