feat: add k8s_namespace() to pull cached namespace #5935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsheaps
force-pushed
the
nsheaps/add-k8s-namespace
branch
from
a9a0946 to
e401a63
Compare
Signed-off-by: Nathan Heaps <nathan.heaps@reddit.com>
nsheaps
force-pushed
the
nsheaps/add-k8s-namespace
branch
from
e401a63 to
537a907
Compare
kylelemons
suggested changes
Sep 9, 2022
| @@ -5765,7 +5766,7 @@ type fixture struct { | |||
| func (f *fixture) newTiltfileLoader() TiltfileLoader { | |||
| dcc := dockercompose.NewDockerComposeClient(docker.LocalEnv{}) | |||
|
|
|||
| k8sContextPlugin := k8scontext.NewPlugin(f.k8sContext, f.k8sEnv) | |||
There was a problem hiding this comment.
missing test coverage, see:
https://sourcegraph.com/github.com/tilt-dev/tilt/-/blob/internal/tiltfile/tiltfile_test.go?L3601:4
Signed-off-by: Nathan Heaps <nathan.heaps@reddit.com>
nsheaps
force-pushed
the
nsheaps/add-k8s-namespace
branch
from
af15d86 to
e8862ce
Compare
|
lgtm, but the build is failing because you need to run |
|
Thanks @nicks , I wasn't paying attention to that check originally because it wasn't running. Will ping for review once CI passes |
kylelemons
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add a
k8s_namespace()function to tiltfiles to allow them to fetch the namespace that tilt is configured to use, regardless of if the kubeconfig changes which namespace or context it's targeted at.Still needs docs update
Closes #5934