Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiltfile: load compose services from multiple projects/directories #5952

Merged
merged 5 commits into from
Oct 25, 2022

Conversation

nicksieger
Copy link
Member

@nicksieger nicksieger commented Oct 10, 2022

  • Load and track multiple compose projects
  • Allow DC resources to be renamed in the event of collisions between multiple projects.
  • Upgrade compose-go to v1.6.0

Fixes #5170.

@nicksieger nicksieger force-pushed the dc-5170 branch 2 times, most recently from 06b32ae to a61890b Compare October 11, 2022 01:18
@nicksieger nicksieger requested review from milas and nicks October 11, 2022 01:43
@nicksieger nicksieger marked this pull request as ready for review October 11, 2022 01:43
internal/tiltfile/tiltfile_state.go Outdated Show resolved Hide resolved
internal/tiltfile/tiltfile_docker_compose_test.go Outdated Show resolved Hide resolved
internal/tiltfile/tiltfile_docker_compose_test.go Outdated Show resolved Hide resolved
internal/tiltfile/k8s.go Outdated Show resolved Hide resolved
@nicksieger nicksieger force-pushed the dc-5170 branch 2 times, most recently from 6c8cb12 to 468c8cd Compare October 21, 2022 20:43
Fixes tilt-dev#5170.

Signed-off-by: Nick Sieger <nick@nicksieger.com>
Signed-off-by: Nick Sieger <nick@nicksieger.com>
Signed-off-by: Nick Sieger <nick@nicksieger.com>
Signed-off-by: Nick Sieger <nick@nicksieger.com>
Signed-off-by: Nick Sieger <nick@nicksieger.com>
Copy link
Member

@nicks nicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nicks
Copy link
Member

nicks commented Oct 25, 2022

will merge this and do a release tomorrow morning

@nicks nicks merged commit 3c99f13 into tilt-dev:master Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support docker-compose configs from multiple directories
2 participants