Ignores IPv6 addresses containing a zone index #5981 #5984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louismrose
force-pushed
the
issue-5981
branch
from
107a3e7 to
c34a346
Compare
louismrose
force-pushed
the
issue-5981
branch
4 times, most recently
from
1b1552d to
23d3ac3
Compare
Fixes tilt-dev#5981 Signed-off-by: Louis Rose <louis.rose@anaplan.com>
louismrose
force-pushed
the
issue-5981
branch
from
23d3ac3 to
f358a6e
Compare
nicksieger
approved these changes
Dec 7, 2022
|
I don't have write perms here, so will wait for somebody else to merge. If there's more to do here, do let me know. Thanks! |
|
feels like this needs a unit test, to ensure someone doesn't break it in the future. i'm really confused why you're hitting this codepath at all, since you're really only supposed to hit this path when you manually specify a host. the default behavior should be to use kubectl's built-in resolution logic. i'm not opposed to this pr, i just worry we're missing a deeper bug here. |
|
There's some context in the linked issue. Apparently some mac OS machines will return an ipv6 address with a zone index when looking up localhost. |
nicks
approved these changes
Dec 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A possible fix for #5981. Ignores IP addresses that contain a zone index when trying to determine which IP address to use for port forwarding.