Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: fix a logic error in scheduling #6018

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Conversation

nicks
Copy link
Member

@nicks nicks commented Jan 14, 2023

This only comes up in the case where nothing else schedules a reconcile. (Lots of things schedule reconciles at random times).

Fixes #6016

@nicks nicks requested review from landism and milas January 14, 2023 00:45
This only comes up in the case where nothing else schedules a reconcile.
(Lots of things schedule reconciles at random times).

Fixes tilt-dev#6016

Signed-off-by: Nick Santos <nick.santos@docker.com>
Copy link
Contributor

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nicks nicks merged commit edd3f8b into tilt-dev:master Jan 17, 2023
@nicks nicks deleted the nicks/requeue branch January 17, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

k8s_grace_period not respected
2 participants