Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockercompose: Add ability to suppress automatic links in UI (#6270) #6328

Merged
merged 4 commits into from
Mar 6, 2024

Conversation

kinland
Copy link
Contributor

@kinland kinland commented Mar 5, 2024

There was a suggestion in #6270 to suppress the "http://localhost:${port}" links that get added automatically when using docker_compose. I liked the idea, so I took a swing at implementing this.

kinland added 4 commits March 4, 2024 21:07
…v#6270)

Signed-off-by: Kinland <16787581+kinland@users.noreply.github.com>
The linting spacing rules must have changed since the last time pkg/model/docker_compose_target.go was touched.

Signed-off-by: Kinland <16787581+kinland@users.noreply.github.com>
…en true (tilt-dev#6270)

Signed-off-by: Kinland <16787581+kinland@users.noreply.github.com>
… ports test (tilt-dev#6270)

Signed-off-by: Kinland <16787581+kinland@users.noreply.github.com>
@kinland
Copy link
Contributor Author

kinland commented Mar 5, 2024

I'm not sure why TestShutdownOnCancel is failing on CircleCI. Seems to work locally:

=== RUN   TestShutdownOnCancel
Running cmd: sh -c "function cleanup()\n{\n  echo \"cleanup time!\"\n  exit 1\n}\n\ntrap cleanup EXIT\nsleep 100"
About to gracefully shut down process 95745
--- PASS: TestShutdownOnCancel (1.01s)

@nicks nicks self-requested a review March 6, 2024 04:46
@nicks nicks merged commit b096000 into tilt-dev:master Mar 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants