docker: remove ping from boot sequence #6331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicks
force-pushed
the
nicks/docker
branch
4 times, most recently
from
511dd6b to
624951a
Compare
this ensures that if the Docker daemon is dead or not responding, it doesn't block tiltfile execution. now that we have reconcilers that are checking the cluster status, i think this is safer than it used to be. fixes #5841 Signed-off-by: Nick Santos <nick.santos@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this ensures that if the Docker daemon
is dead or not responding, it doesn't
block tiltfile execution.
now that we have reconcilers that are
checking the cluster status, i think this
is safer than it used to be.
fixes #5841
Signed-off-by: Nick Santos nick.santos@docker.com