cmd: add the ability to attach a pty to a local command #6379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicks
force-pushed
the
nicks/stdin
branch
7 times, most recently
from
44a25e0 to
4ac3010
Compare
Note that this doesn't wire anything up to the tiltfile. That will come in a subsequent PR. Signed-off-by: Nick Santos <nick.santos@docker.com>
nicks
added a commit
that referenced
this pull request
May 31, 2024
This reverts commit 69a74bb. Signed-off-by: Nick Santos <nick.santos@docker.com>
nicks
added a commit
that referenced
this pull request
May 31, 2024
* Revert "tiltfile: add stdin_mode='pty' to local_resouce() (#6382)" This reverts commit 20ab76b. Signed-off-by: Nick Santos <nick.santos@docker.com> * Revert "cmd: add the ability to attach a pty to a local command (#6379)" This reverts commit 69a74bb. Signed-off-by: Nick Santos <nick.santos@docker.com> --------- Signed-off-by: Nick Santos <nick.santos@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this doesn't wire anything up to
the tiltfile. That will come in a subsequent PR.
Signed-off-by: Nick Santos nick.santos@docker.com