tiltfile/helm: handle parsing version strings without v prefix
#6408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aybabtme
force-pushed
the
parse-helm-version-with-pkgx-bundling
branch
2 times, most recently
from
0393afe to
8f17dd4
Compare
`helm version` doesn't necessarily return a string with `v` in the prefix, as it depends how it's packaged and bundles. For instance when running helm with pkgx.sh: ``` $ pkgx helm version --client --short 3.15.2 ``` (due to https://github.com/pkgxdev/pantry/blob/main/projects/helm.sh/package.yml#L22) Without this change, tilt fails to parse the version with error: ``` Error in helm: could not parse Helm version from string: "3.15.2\n" ``` This fixes that. Signed-off-by: Antoine Grondin <antoinegrondin@gmail.com>
aybabtme
force-pushed
the
parse-helm-version-with-pkgx-bundling
branch
from
8f17dd4 to
d07b7e9
Compare
|
Not sure how to get CI to run. |
|
ugh, circleci has been really awful the past couple weeks, let me kick it to see if it resolves. |
nicks
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
helm versiondoesn't necessarily return a string withvin the prefix, as it depends how it's packaged and bundled. For instance when running helm with pkgx.sh (for pinning tool dependencies):(due to https://github.com/pkgxdev/pantry/blob/main/projects/helm.sh/package.yml#L22)
Without this change, tilt fails to parse the version with error:
This fixes that.