Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: use dark color scheme to match UI #6429

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

metonym
Copy link
Contributor

@metonym metonym commented Aug 30, 2024

I use Tilt daily.

This is an unsolicited suggestion for the web UI styling. Because the Tilt UI is a dark theme, color-scheme: dark hints to browsers to apply similar adjustments to the interface. In this case, the change is most notable with the scrollbars.

Before

By default, scrollbars rendered by Chrome for overflowing content are light-themed.

tilt-before

After

By applying the declaration on the html root element, the browser applies a dark theme to the scrollbars on the body and the components list.

tilt-after

Copy link
Member

@nicks nicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nicks nicks merged commit 9955b4c into tilt-dev:master Aug 30, 2024
6 of 7 checks passed
@metonym metonym deleted the color-scheme-dark branch August 30, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants