engine: fix a bug in cluster connection checks #6454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before this change, if you were deploying to both a DockerCompose engine and a Kube cluster, we sometimes wouldn't correctly synchronize the cluster connections. this led to problems where we would try to deploy before the connection had been established properly. fixes #6453 Signed-off-by: Nick Santos <nick.santos@docker.com>
nicks
force-pushed
the
nicks/reference
branch
from
68c1bf1 to
00ab5b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before this change, if you were deploying
to both a DockerCompose engine and a Kube
cluster, we sometimes wouldn't correctly
synchronize the cluster connections.
this led to problems where we would try
to deploy before the connection had been
established properly.
fixes #6453
Signed-off-by: Nick Santos nick.santos@docker.com