cluster: bug fixes to kubeconfig gen #6459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicksieger
approved these changes
Nov 4, 2024
- treat failure to write kubeconfigs as a cluster connection failure - if runtime dir is not available, write kubeconfigs in a state dir instead (spec says that if the runtime dir doesn't exist, it's up to the implementer to find a better dir, but isn't opinionated about what dir we use) Signed-off-by: Nick Santos <nick.santos@docker.com>
nicks
force-pushed
the
nicks/runtime-dir
branch
from
febd587 to
8378677
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connection failure
kubeconfigs in a state dir instead
(spec says that if the runtime dir doesn't exist,
it's up to the implementer to find a better dir,
but isn't opinionated about what dir we use)
Signed-off-by: Nick Santos nick.santos@docker.com