model: fast build fields to dockerInfo.buildDetails [ch1136] #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jazzdan
reviewed
Dec 21, 2018
internal/model/docker_info.go
Outdated
| @@ -50,3 +50,17 @@ type FastBuild struct { | |||
|
|
|||
| func (FastBuild) buildDetails() {} | |||
| func (fb FastBuild) Empty() bool { return reflect.DeepEqual(fb, FastBuild{}) } | |||
|
|
|||
| // func (m1 Manifest) stepsEqual(s2 []Step) bool { | |||
jazzdan
approved these changes
Dec 21, 2018
| @@ -104,24 +97,33 @@ func (m Manifest) Dockerignores() []Dockerignore { | |||
| func (m Manifest) LocalPaths() []string { | |||
| if sbInfo := m.StaticBuildInfo(); !sbInfo.Empty() { | |||
There was a problem hiding this comment.
Could we transform this in to a case statement?
There was a problem hiding this comment.
not really, cuz we're looking at the type of two different fields :-/
internal/model/manifest.go
Outdated
| return fmt.Errorf( | ||
| "[validate] mount.LocalPath must be an absolute path (got: %s)", m.LocalPath) | ||
|
|
||
| if fbInfo := m.FastBuildInfo(); !fbInfo.Empty() { |
There was a problem hiding this comment.
This is a lot of indentation, could we move the check about?
if fbInfo := m.FastBuildInfo(); fbInfo.Empty() {
return nil
}
// ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @jazzdan, @nicks,
Please review the following commits I made in branch maiamcc/fast-build:
8d94a3f (2018-12-21 16:10:23 -0500)
model: fast build fields to dockerInfo.buildDetails
Code review reminders, by giving a LGTM you attest that: