Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: in verbose mode, print more info on what files we tar #972

Merged
merged 1 commit into from
Jan 10, 2019
Merged

build: in verbose mode, print more info on what files we tar #972

merged 1 commit into from
Jan 10, 2019

Conversation

maiamcc
Copy link
Contributor

@maiamcc maiamcc commented Jan 10, 2019

Hello tbd,

Please review the following commits I made in branch maiamcc/verbose-tar-info:

fdc795a (2019-01-10 12:15:00 -0500)
build: in verbose mode, print more info on what files we tar

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@maiamcc maiamcc requested a review from jazzdan January 10, 2019 19:10
jazzdan
jazzdan approved these changes Jan 10, 2019
View reviewed changes
Copy link
Contributor

@jazzdan jazzdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maiamcc
Copy link
Contributor Author

maiamcc commented Jan 10, 2019

in #971 a user expressed that just seeing fast_build output the docker step ADD . / was confusing -- hopefully this makes which files we're adding a little more transparent

@maiamcc maiamcc merged commit 1d19f07 into master Jan 10, 2019
@maiamcc maiamcc deleted the maiamcc/verbose-tar-info branch January 10, 2019 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jazzdan jazzdan jazzdan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maiamcc @jazzdan