Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(Windows): cache xmake dependencies #36

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

poirierlouis
Copy link
Collaborator

Add restore-keys to reuse partial caches.

@poirierlouis
Copy link
Collaborator Author

poirierlouis commented Nov 30, 2024

I can see that protobuf is the culprit...

@poirierlouis poirierlouis marked this pull request as draft November 30, 2024 00:34
@maximegmd
Copy link
Member

I can see that protobuf is the culprit...

it always is lol

@poirierlouis
Copy link
Collaborator Author

poirierlouis commented Nov 30, 2024

it always is lol

Is there no way to cache it, maybe manually? 10min is such a waste... I'm not sure, downloaded archive is about protobuf and protobuf-cpp?

@maximegmd
Copy link
Member

I am not sure why that happens, I am not very knowledgeable when it comes to caching in github. We are probably doing it incorrectly but I can't really say why...

@poirierlouis
Copy link
Collaborator Author

I'm learning too and couldn't find an explanation so far. I'll keep tweaking settings and see what the runner logs out...

@poirierlouis poirierlouis force-pushed the ci/xmake-cache-deps branch 2 times, most recently from 6c4b7c8 to 44d36f9 Compare November 30, 2024 13:21
Add restore-keys to reuse partial caches.
Change how xmake itself is cached, make sure to use unique cache keys between xmake itself and xmake dependencies.
Use xmake v2.9.6 which fix cache dependency issue regarding protobuf.
@poirierlouis poirierlouis self-assigned this Nov 30, 2024
@poirierlouis poirierlouis marked this pull request as ready for review November 30, 2024 13:37
@maximegmd maximegmd merged commit 7df3394 into tiltedphoques:main Nov 30, 2024
2 checks passed
@poirierlouis poirierlouis deleted the ci/xmake-cache-deps branch November 30, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants