Game exe path command line argument #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ex. `SkyrimTogether.exe --exePath C:\Path\To\Game\SkyrimSE.exe`
Force67
requested changes
Sep 9, 2024
| { | ||
| if (std::strcmp(aArgv[i], "-r") == 0) | ||
| aAskSelect = true; | ||
| else if (std::strcmp(aArgv[i], "--exePath") == 0) |
There was a problem hiding this comment.
This is a bit dangerous. The problem arises because there's no guarantee that aArgv[i + 1] is a valid memory location. If "--exePath" is the last argument in the command line, i + 1 would be out of bounds of the aArgv array.
There was a problem hiding this comment.
Should be better in 50488e3
(clang formatted after)
|
|
||
| bool PathArgument(const std::string& acPath) | ||
| { | ||
| g_exePath = std::wstring(acPath.begin(), acPath.end()); |
There was a problem hiding this comment.
This is not very pretty with the global variables :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the game exe portion of #627
I am not sure how SKSE wouldn't be loaded if it is installed correctly so I will leave that for a different PR if it is necessary.
ex.
SkyrimTogether.exe --exePath C:\Path\To\Game\SkyrimSE.exeor
SkyrimTogether.exe --exePath "C:\Path\With a space\SkyrimSE.exe"