Sync Remove Spell / Magic Cancel

[rfortier]

I'm just the PR monkey, this fix is contributed by @MostExcellent.

This allows the function that explicitly removes magic effects to sync when applied to a player. The Remove Spell function is in vanilla Skyrim but won't be synced by STR without this fix.

Updated to newest newest /dev branch, needed to move Actor::RemoveSpell to Actor.cpp

This functionality has been in the Animation branch since before the release of 1.6.7, just got the author's permission to PR/merge it.

[RobbeBryssinck]

I'm not sure what this is supposed to do. Can you give an example of what bug this would fix for example? For example, are magic effects not cancelled properly without this PR, and if so, which ones?

[rfortier]

I'm not sure what this is supposed to do. Can you give an example of what bug this would fix for example? For example, are magic effects not cancelled properly without this PR, and if so, which ones?

Suspected I would get this question. But I don't know where vanilla Skyrim uses it. I guess I can try a breakpoint and see if it fires with the way I play. MCO players discovered it because some effects in MCO weren't working/syncing right, and found it was using this vanilla Skyrim function that wasn't being synced.

Well, so I did that. The first thing I tried called RemoveSpell, changing my standing stone blessing. So it must happen a lot in the vanilla game. Understanding all the implications is a lot harder, of course.

This was my pure-vanilla, no-mods game.

[marceloarc]

This pr fixed an annoying bug where healing hands was not working very well, i'm sure this fixed other bugs as well

[rfortier]

This is the first time I implemented an It() / HookIt() / RealIt() pattern, so I pushed the branch early for comment on whether I got all the parts in the right places.

I'll resolve the review comments after I finish testing.

[rfortier]

Changes are in and tested to the extent I can. I recommend getting an MCO user to verify, or someone who knows of a reliable vanilla test.