Midi events uint offset #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use unsigned data type for midi event offset, see issue tim-janik#26. Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
…im-janik#26) Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
…m-janik#26) Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
…gned Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
…gned Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
…signed Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
…ead) Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
tim-janik
force-pushed
the
midi-events-uint-offset
branch
from
c9339b4
to
0d5c6c8
Compare
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #26, midi events should not contain negative frame offsets. Here is a PR for that.
AUDIO_BLOCK_MAX_RENDER_SIZEas I'm not sure if that depends on anything else (and 2048 is certainly enough for all use cases I can think of), but in principle we now support frame offsets up to 4095.