Fix Rails 5.2 and 6.x Docker images #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were 2 issues that were breaking the build and tests. 1. Updating Ruby Gems itself without specifying a version causes it to update to the latest version which requires Ruby 3. Instead, we specify the latest version compatible with Ruby 2.6. Compatibility versions found here: https://rubygems.org/api/v1/versions/rubygems-update.json 2. The version of Alpine Linux shipping with the Ruby 2.6 image is missing a shared library needed to load nokogiri. Adding `gcompat` corrects this. More information found here: github/pages-gem#839
tim-kuntz
changed the title
|
Closing for a more complete fix in pull request #2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were 2 issues that were breaking the build and tests.
Compatibility versions found here:
https://rubygems.org/api/v1/versions/rubygems-update.json
gcompatcorrects this.More information found here:
github/pages-gem#839