Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 11.x Compatibility #49

Merged
merged 16 commits into from
Mar 13, 2024

Conversation

laravel-shift
Copy link
Contributor

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 11.x.

Before merging, you need to:

  • Checkout the l11-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

@laravel-shift
Copy link
Contributor Author

⚠️ The latest version of Laravel has a dependency for phpunit/phpunit of ^10.5. If you would like to also upgrade your tests, you may run the PHPUnit 10 Shift for free.

@laravel-shift
Copy link
Contributor Author

⚠️ Shift detected a dependency for the laravel/framework. Unless you have a special requirement for depending on the entire Laravel framework, it's recommended to add dependencies for the specific illuminate packages instead.

@laravel-shift
Copy link
Contributor Author

⚠️ Shift detected GitHub Actions which run jobs using a version matrix. Shift attempted to update your configuration for Laravel 11. However, you should review these changes to ensure the desired combination of versions are built for your package.

@laravel-shift
Copy link
Contributor Author

⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/json-api.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "timacdonald/json-api": "dev-l11-compatibility",
    }
}

Finally, run: composer update

Copy link

@lloricode lloricode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add php8.3, thank you

Copy link

@lloricode lloricode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can github action workflow separate files? it is difficult to track all workflows here

- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: '8.1'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use php 8.3 as latest version

Copy link
Owner

@timacdonald timacdonald Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is okay as it is just linting / fixing.

.github/workflows/main.yml Outdated Show resolved Hide resolved
@lloricode
Copy link

will make PR as soon as I vack to my machine

@timacdonald timacdonald merged commit aed50a8 into timacdonald:main Mar 13, 2024
17 checks passed
@lloricode
Copy link

hi @timacdonald, it seems not updated the https://packagist.org/packages/timacdonald/json-api

@lloricode
Copy link

hi @timacdonald, it seems not updated the https://packagist.org/packages/timacdonald/json-api

ow, nervermind, thanks a lot @timacdonald

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants