-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laravel 11.x Compatibility #49
Laravel 11.x Compatibility #49
Conversation
|
|
|
⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch. To do so, temporarily add Shift's fork to the {
"repositories": [
{
"type": "vcs",
"url": "https://github.com/laravel-shift/json-api.git"
}
]
} Then update your dependency constraint to reference this branch: {
"require": {
"timacdonald/json-api": "dev-l11-compatibility",
}
} Finally, run: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add php8.3, thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can github action workflow separate files? it is difficult to track all workflows here
- name: Setup PHP | ||
uses: shivammathur/setup-php@v2 | ||
with: | ||
php-version: '8.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use php 8.3 as latest version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is okay as it is just linting / fixing.
will make PR as soon as I vack to my machine |
hi @timacdonald, it seems not updated the https://packagist.org/packages/timacdonald/json-api |
ow, nervermind, thanks a lot @timacdonald |
This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 11.x.
Before merging, you need to:
l11-compatibility
branchIf you do find an issue, please report it by commenting on this PR to help improve future automation.