2.0 Discussion

[timarney]

TLDR:
See Readme notes for alternatives to this repo:

Also see - #343 as of Create React App 2.1.2 (there's a breaking issue) versions prior not using the utility functions from this repo still worked.

---

Opening this to discuss work to be done in a 2.0 release.

One thing I would like thoughts on dropping support for older versions of Webpack.

i.e. this part of code

// Older versions of webpack have `plugins` on `loader.query` instead of `loader.options`.
  const options = loader.options || loader.query;
  options.plugins =  [pluginName].concat(options.plugins || []);
  return config;

[Guria]

We should invest some time into tests. But it isn't blocks major release I suppose

[timarney]

Would love to get some tests in place. If you have any proposal as far as best setup for that would be +1

[Guria]

We also can drop passing process.env.NODE_ENV as argument to rewires.

[timarney]

As per my note here
mobxjs/mobx-react#381 (comment)

should make some adjustments for plugin ordering i.e. https://github.com/loganfsmyth/babel-plugin-transform-decorators-legacy#note-order-of-plugins-matters

[andriijas]

Okey lets get the party started, i have a pending PR,

@timarney can you create a next branch of react-app-rewired and we can accumulate changes there?

[timarney]

There's a branch now.

[andriijas]

react-scripts 2.0 is happening, more info here:
facebook/create-react-app#3815

• Update less rewire to support new CSS modules in react-scripts 2.0 - fixed in add support for less modules in react-scripts 2.0 #191
• Deprecate support for old versions of react-scripts as mentioned above
• Update rewires if needed

When CRA2 is out:

• Update README to make it clear that react-app-rewired 2.0 only works with react-scripts 2.0
• Update LESS readme to point to CSS module documentation in CRA

[Guria]

Is it critical to drop react-scripts@1.x support?
Do we expect critical config changes on CRA side that hard to manage on rewired side?

[andriijas]

Not critical but Id argue that there is no reason to upgrade rewire if you are holding of react-scripts.

One of the new features in cra2 is css modules so naturally the less rewire should support it in rewire 2 but it will be a lot more job to add css module support to older versions because we only extend the config, not adding anything new.

react-scripts 1.x => rewire 1.x , react-scripts 2 => rewire 2.x feels like a natural mapping which is easy for users to get.

[pauliusuza]

Would it be possible for you to publish a test version of react-app-rewired under @next in npm?

[andriijas]

@timarney now that there are changes that breaks rewire with cra2, can we have a pre release? I just pushed a minor tweak to next branch.

[timarney]

Should be there now:

next: 2.0.0
➜ react-app-rewired git:(next)

[andriijas]

Thanks.

I figured its better to hold of cleaning of supporting old webpack config formats untill webpack 4 is in cra2.

[unconfident]

After thinking about #204 for a while I think I'd like to see better utility for rule/loader list traversal and manipulation. What I'd like to be able to out of the box with utils provided by rewire v2 or earlier is:

• Improved search logic that resembles Webpack's logic more closely.
  Basically Expand getLoader method to iterate over rule.loaders and rule.loader when applicable #204, will try to submit PR sooner or later

• Being able to find every rule that includes specific loader instead of just one

• Proper destinction between a Rule and UseEntry, searching Rule by loader name or use entry

• Inserting loader before or after specific rule

  • With an automatic conversion of a shorthand to list style. I.e. converting

    {
      test: /\.jsx$/,
      loader: 'babel-loader',
      options: { ... } 
    }

    to

    {
      test: /\.jsx$/,
      use: [
        { loader: 'babel-loader', options: { ... } }
      ]
    }

• Changing loader options that would transparently convert string shorthand to a UseEntry object. I.e.

  { test: /\.jsx$/,
    use: [
      'babel-loader'
    ] }

  to the code block above