-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Mock react-scripts 'config' folder #593
Conversation
…ebpackDevServer.config.js`
Thanks @bencergazda --- I think I'll spin up a "next" release for this for testing prior to a real release. @dawnmist outside of ensuring this is backwards compatible any other thoughts? |
…`config/webpackDevServer.config.js`
marged. @bencergazda does this feel like a feature release to you or a patch |
@timarney I'd rather say this is a feature! |
Published 2.2.0 Thanks for the PRs |
@timarney Sorry, but after the first install, I realized that we need to add This doesn't affect the core functionality, but the mocked config folder won't be accessible until we fix this. Submitted #606 with the correction. |
react-scripts
has aconfig
folder that contains the base webpack or devServer configuration. Some 3rd party packages (like@storybook/preset-create-react-app
) require these files, serving as a base for their own configuration.This PR:
config/webpack.config.js
,config/webpackDevServer.config.js
andconfig/paths.config.js
files that export the rewired configuration EVEN if we didn't call thereact-app-rewired
command.This makes storybook (and probably many other packages) plug and play also for the rewired apps.