Reorder twig files #162
Merged
Reorder twig files #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gchtr
approved these changes
May 21, 2024
There was a problem hiding this comment.
This is a nice update! 👍
And yes, I agree with you that archive.twig in combination with {{ parent() }} maybe is a bit complicated for a starter theme.
We could also just copy over the relevant contents from index.twig to make it easier to start working with archive.twig.
Levdbas
commented
May 21, 2024
Levdbas
commented
May 21, 2024
|
@gchtr , modified the archive.twig and did some other minor tweaks, see comments. |
gchtr
reviewed
May 21, 2024
page.php
Outdated
| @@ -17,4 +17,4 @@ | |||
| $context = Timber::context(); | |||
| $post = $context['post']; | |||
|
|
|||
| Timber::render(array('page-' . $post->post_name . '.twig', 'page.twig'), $context); | |||
| Timber::render(array('templates/page-' . $timber_post->post_name . '.twig', 'templates/page.twig'), $context); | |||
There was a problem hiding this comment.
$timber_post is not defined here, right?
Co-authored-by: Lukas Gaechter <lukas.gaechter@mind.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first changes in a larger set of changes that I am going to propose.
Related:
Issue
Since the creation of the starter theme a lot has happened in PHP, WordPress and Timber. I want to make the starter-theme a more modern starting point for custom theme development.
Solution
This particular PR focusses on moving twig files to subdirectories for make a separation between the type of twig files.
Impact
A better, less confusing, start with templating in Timber.
Usage Changes
none
Considerations
-archive.twig is still a bit overkill, maybe we can simplify that as well by removing the parent() function