NetworkPkg/NvmeOfDxe: Fix SSNS Primary HFI Descriptor Index assignment #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HfiHeader was always pointing to a head of the HFI Descriptor List and its index was assigned to a SSNS Primary HFI Descriptor Index, effectively always filling it with a value of '1'. The real HFI index to be used was added only as a first Secondary HFI Descriptor Index. In a multipath scenario where separate SSNS records were defined for every NIC/HFI, this led to connection failures due to mismatched network subnets. Signed-off-by: Tomas Bzatek <tbzatek@redhat.com>
|
This is based on Martin's comment in linux-nvme/libnvme#766 (comment) (as referenced in #29) and I created this patch as an experiment. Turns out it did the trick and made a multipath scenario with separate SSNS records for each HFI testable in Linux at least. I'm not sure this is entirely correct and only tested the multipath scenario so far. |
|
Fixed in #35 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HfiHeader was always pointing to a head of the HFI Descriptor List and its index was assigned to a SSNS Primary HFI Descriptor Index, effectively always filling it with a value of '1'. The real HFI index to be used was added only as a first Secondary HFI Descriptor Index.
In a multipath scenario where separate SSNS records were defined for every NIC/HFI, this led to connection failures due to mismatched network subnets.