Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixed names of breakpoints #18

Closed
hans2103 opened this issue Aug 3, 2018 · 2 comments
Closed

mixed names of breakpoints #18

hans2103 opened this issue Aug 3, 2018 · 2 comments

Comments

@hans2103
Copy link
Contributor

hans2103 commented Aug 3, 2018

the current names of the breakpoints are:

$alpha: 320px !default;
$alpha--plus: 440px !default;
$beta: 560px !default;
$charlie: 768px !default;
$delta: 1024px !default;
$echo: 1112px !default;
// The above values minus 1px to be used for min-max media queries
$alpha--plus-min: $alpha--plus - 1px !default;
$beta-min: $beta - 1px !default;
$charlie-min: $charlie - 1px !default;
$delta-min: $delta - 1px !default;
$echo-min: $echo - 1px !default;

This seems like the Greek alphabet, but it fails on Charlie which is part of the NATO alphabet.

Choose one, not both.
I suggest to choose for the NATO phonetic alphabet.
Alfa, Bravo, Charlie, Delta, Echo

This needs a refactor of the framework. I'll create a PR.

@hans2103
Copy link
Contributor Author

hans2103 commented Aug 3, 2018

created PR "mixed names of breakpoints" #19

@robinpoort
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants