Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixed names of breakpoints #19

Merged
merged 3 commits into from
Aug 14, 2018
Merged

mixed names of breakpoints #19

merged 3 commits into from
Aug 14, 2018

Conversation

hans2103
Copy link
Contributor

@hans2103 hans2103 commented Aug 3, 2018

the current names of the breakpoints are:

$alpha: 320px !default;
$alpha--plus: 440px !default;
$beta: 560px !default;
$charlie: 768px !default;
$delta: 1024px !default;
$echo: 1112px !default;
// The above values minus 1px to be used for min-max media queries
$alpha--plus-min: $alpha--plus - 1px !default;
$beta-min: $beta - 1px !default;
$charlie-min: $charlie - 1px !default;
$delta-min: $delta - 1px !default;
$echo-min: $echo - 1px !default;

This seems like the Greek alphabet, but it fails on Charlie which is part of the NATO alphabet.

Choose one, not both.
I suggest to choose for the NATO phonetic alphabet.
Alfa, Bravo, Charlie, Delta, Echo

This needs a refactor of the framework. I'll create a PR.

@robinpoort robinpoort self-requested a review August 14, 2018 07:32
Copy link
Contributor

@robinpoort robinpoort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the .idea file from .gitignore? Not everybody is using phpStorm. And we don't want to pollute the gitignore file with all possible folders for different editors. You can exclude the file so it won't show up in your changed files everytime.

@hans2103
Copy link
Contributor Author

@robinpoort .idea has been removed from .gitignore

@robinpoort robinpoort merged commit 37dfb92 into timble:master Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants