Skip to content

Commit

Permalink
Merge pull request #354 from timbray/1.4
Browse files Browse the repository at this point in the history
kaizen: Move to v1.4
  • Loading branch information
timbray authored Aug 30, 2024
2 parents 8cfc1f2 + c7ae746 commit cd6bc6b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Quamina [welcomes contributions](CONTRIBUTING.md).

### Status

This is version 1.3.0 of Quamina. In future, the API will be changed only additively.
This is version 1.4.0 of Quamina. In future, the API will be changed only additively.

Note that we have documented more APIs than are actually
fully implemented, with the intent of showing direction.
Expand Down
4 changes: 2 additions & 2 deletions numbits.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ const MaxBytesInEncoding = 10
// the byte-string encoding is big-endian, trailing zeroes don't count, so the encoding can be as short as
// one byte.
// Idea and some code by Axel Wagner
func (nb numbits) toQNumber() []byte {
func (nb numbits) toQNumber() qNumber {
// Iterate through the numbits 7 bits at a time, right to left, first bypassing bits that generate
// trailing zeroes in the encoded form. Note that index could go to 0 if the numbits value was uint(0)
// but that value represents NaN and can't appear in JSON
Expand All @@ -54,5 +54,5 @@ func (nb numbits) toQNumber() []byte {
b[index] = byte(nb & 0x7f)
nb >>= 7
}
return b[:]
return b
}

1 comment on commit cd6bc6b

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Go Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: cd6bc6b Previous: 78e2ec8 Ratio
BenchmarkCityLots 11160 ns/op 1782 B/op 103 allocs/op 5592 ns/op 773 B/op 31 allocs/op 2.00
BenchmarkCityLots - ns/op 11160 ns/op 5592 ns/op 2.00
BenchmarkCityLots - B/op 1782 B/op 773 B/op 2.31
BenchmarkCityLots - allocs/op 103 allocs/op 31 allocs/op 3.32
Benchmark_JsonFlattner_Evaluate_ContextFields 989 ns/op 72 B/op 8 allocs/op 726.2 ns/op 56 B/op 4 allocs/op 1.36
Benchmark_JsonFlattner_Evaluate_ContextFields - ns/op 989 ns/op 726.2 ns/op 1.36
Benchmark_JsonFlattner_Evaluate_ContextFields - B/op 72 B/op 56 B/op 1.29
Benchmark_JsonFlattner_Evaluate_ContextFields - allocs/op 8 allocs/op 4 allocs/op 2

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.